I spent the day installing tokico illumina and h&r springs new strut mounts all the way round took the car out for test drive only problem is getting a knocking noise from the right front what did i do wrong please help.

 

Check the seating of the spring... it might not be sitting right....

By the way, your posts tend to be hard to understand sometimes... to prevent any miscommunication or misunderstanding, try using some punctuation and full sentences every now and then... its for your own good...

 

Thanks for the information i will check first thing in the morning. If the seating is ok what else could been the problem.

 

Most likely your spring is not seated properly.